[Merged by Bors] - Remove bevy_dynamic_plugin as a default#2578
Closed
DJMcNab wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Remove bevy_dynamic_plugin as a default#2578DJMcNab wants to merge 1 commit intobevyengine:mainfrom
DJMcNab wants to merge 1 commit intobevyengine:mainfrom
Conversation
It doesn't compile on wasm, and it's full of footguns
alice-i-cecile
approved these changes
Jul 31, 2021
bjorn3
approved these changes
Jul 31, 2021
bjorn3
added
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 1, 2021
It doesn't compile on wasm, and it's full of footguns # Objective - If bevy is used with default features on wasm, there's more of a chance it will compile - Note that I haven't done a full audit - it's possible that there are other problematic crates ## Solution - `bevy_dynamic_plugin` is no longer a default plugin - I've also done an accidental drive by reformatting of the root `Cargo.toml`, as I have [Even Better Toml](https://github.com/tamasfe/taplo) installed. - (Please, rustfmt do this for us)
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't compile on wasm, and it's full of footguns
Objective
Solution
bevy_dynamic_pluginis no longer a default pluginCargo.toml, as I have Even Better Toml installed.