[Merged by Bors] - Better error message for unsupported shader features Fixes #869#2598
Closed
myisaak wants to merge 1 commit intobevyengine:mainfrom
Closed
Conversation
myisaak
force-pushed
the
better_error_message_for_unsupported_shader_features
branch
from
8ac1075 to
64a759f
Compare
DJMcNab
added
A-Rendering
Member
|
bors try |
DJMcNab
reviewed
Aug 6, 2021
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Approval pending formatting being fixed
This is one of the few cases where I think rustfmt's formatting is significantly worse. However, it's still better just to stick with rustfmt's formatting.
You should be able to reformat by using
cargo fmt --all
Contributor
myisaak
force-pushed
the
better_error_message_for_unsupported_shader_features
branch
from
64a759f to
347ddb7
Compare
DJMcNab
approved these changes
Aug 7, 2021
Member
|
could you mention |
mockersf
approved these changes
Aug 9, 2021
Contributor
Author
|
Done. |
mockersf
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2021
# Objective - Provides more useful error messages when using unsupported shader features. ## Solution Fixes #869 - Provided a error message as follows (adding name, set and binding): ``` Unsupported shader bind type CombinedImageSampler (name noiseVol0, set 0, binding 9) ```
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution Fixes #869