Skip to content

[Merged by Bors] - Cleanup FromResources#2601

Closed
Davier wants to merge 2 commits intobevyengine:mainfrom
Davier:cleanup_from_resources
Closed

[Merged by Bors] - Cleanup FromResources#2601
Davier wants to merge 2 commits intobevyengine:mainfrom
Davier:cleanup_from_resources

Conversation

@Davier
Copy link
Contributor

@Davier Davier commented Aug 5, 2021

Objective

  • Clean up remaining references to the trait FromResources, which was replaced in favor of FromWorld during the ECS rework.

Solution

  • Remove the derive macro for FromResources
  • Change doc references of FromResources to FromWorld

(this is the first item in #2576)

FromResources was replaced in favor of FromWorld during the ECS rework.
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 5, 2021
@NiklasEi NiklasEi added C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Aug 6, 2021
Copy link
Member

@NiklasEi NiklasEi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some duplication with #2577, but only trivial changes in some doc comments.

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 9, 2021
@cart
Copy link
Member

cart commented Aug 13, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 13, 2021
## Objective

- Clean up remaining references to the trait `FromResources`, which was replaced in favor of `FromWorld` during the ECS rework.

## Solution

- Remove the derive macro for `FromResources`
- Change doc references of `FromResources` to `FromWorld`

(this is the first item in #2576)
@bors bors bot changed the title Cleanup FromResources [Merged by Bors] - Cleanup FromResources Aug 13, 2021
@bors bors bot closed this Aug 13, 2021
@Davier Davier deleted the cleanup_from_resources branch October 19, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants