[Merged by Bors] - Update EntityMut's location in push_children() and insert_children()#2604
Closed
Davier wants to merge 3 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Update EntityMut's location in push_children() and insert_children()#2604Davier wants to merge 3 commits intobevyengine:mainfrom
Davier wants to merge 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Aug 5, 2021
Member
|
Actually, could you add your previously crashing code as a regression test? |
DJMcNab
approved these changes
Aug 6, 2021
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
The changes I'd suggest are only for internal documentation, and otherwise this looks good.
alice-i-cecile
approved these changes
Aug 8, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Aug 9, 2021
Member
|
Thats a pretty nasty bug. Nice catch! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
…2604) ## Objective This code would result in a crash: ```rust use bevy::prelude::*; fn main() { let mut world = World::new(); let child = world.spawn().id(); world.spawn().push_children(&[child]); } ``` ## Solution Update the `EntityMut`'s location after inserting a component on the children entities, as it may have changed.
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This code would result in a crash:
Solution
Update the
EntityMut's location after inserting a component on the children entities, as it may have changed.