Closed
Conversation
Member
|
I this is a fine change by itself, but it feels like there should be a solution which is more integrated into the ECS itself, somehow Like these locks should not be needed, and instead the mutability 'locking' could be managed by the scheduler. |
hanabi1224
force-pushed
the
mutable-timestep
branch
from
69b0cd4 to
80c1e71
Compare
hanabi1224
commented
Aug 11, 2021
|
|
||
| pub fn with_label(mut self, label: &str) -> Self { | ||
| self.state.label = Some(label.to_string()); | ||
| pub fn with_label(mut self, label: impl Into<String>) -> Self { |
Author
There was a problem hiding this comment.
this impl Into<String> change is irrelevant, it saves an extra string clone when label String is created on the fly and user just want to hand over ownership, which is not allowed with a &str parameter
alice-i-cecile
added
A-Core
C-Usability
Member
|
@maniwani, what do you want to do with this one? |
alice-i-cecile
added
X-Needs-SME
Member
|
I think we can tackle this issue in #5752 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution