[Merged by Bors] - Implement Clone for Fetches#2641
Closed
msvbg wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Implement Clone for Fetches#2641msvbg wants to merge 4 commits intobevyengine:mainfrom
msvbg wants to merge 4 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
Member
|
Since the access in |
Contributor
Author
|
|
cart
approved these changes
Aug 13, 2021
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
Nice catch! This is all safe. We could merge this as-is, but theres one place to improve flexibility (see comment).
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2021
# Objective
This:
```rust
use bevy::prelude::*;
fn main() {
App::new()
.add_system(test)
.run();
}
fn test(entities: Query<Entity>) {
let mut combinations = entities.iter_combinations_mut();
while let Some([e1, e2]) = combinations.fetch_next() {
dbg!(e1);
}
}
```
fails with the message "the trait bound `bevy::ecs::query::EntityFetch: std::clone::Clone` is not satisfied".
## Solution
It works after adding the naive clone implementation to EntityFetch. I'm not super familiar with ECS internals, so I'd appreciate input on this.
Contributor
|
Build failed: |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2021
# Objective
This:
```rust
use bevy::prelude::*;
fn main() {
App::new()
.add_system(test)
.run();
}
fn test(entities: Query<Entity>) {
let mut combinations = entities.iter_combinations_mut();
while let Some([e1, e2]) = combinations.fetch_next() {
dbg!(e1);
}
}
```
fails with the message "the trait bound `bevy::ecs::query::EntityFetch: std::clone::Clone` is not satisfied".
## Solution
It works after adding the naive clone implementation to EntityFetch. I'm not super familiar with ECS internals, so I'd appreciate input on this.
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This:
fails with the message "the trait bound
bevy::ecs::query::EntityFetch: std::clone::Cloneis not satisfied".Solution
It works after adding the naive clone implementation to EntityFetch. I'm not super familiar with ECS internals, so I'd appreciate input on this.