[Merged by Bors] - Reduce visibility of various types and fields #2690
Closed
bjorn3 wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Reduce visibility of various types and fields #2690bjorn3 wants to merge 1 commit intobevyengine:mainfrom
bjorn3 wants to merge 1 commit intobevyengine:mainfrom
Conversation
bjorn3
added
A-ECS
DJMcNab
approved these changes
Aug 19, 2021
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Makes sense, although I might ask you not to include the resolve_unknown commit because of my pr which does something similar but keeps the method.
to match the visibility of the containing module or type
bjorn3
force-pushed
the
ecs_improvements2
branch
from
92a3fc6 to
d092e81
Compare
bjorn3
changed the title
mockersf
approved these changes
Aug 19, 2021
mockersf
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commits.