[Merged by Bors] - Sub app label changes#2717
Closed
cart wants to merge 7 commits intopipelined-renderingfrom
Closed
[Merged by Bors] - Sub app label changes#2717cart wants to merge 7 commits intopipelined-renderingfrom
cart wants to merge 7 commits intopipelined-renderingfrom
Conversation
64 tasks
alice-i-cecile
approved these changes
Aug 24, 2021
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Other than my error reporting nit, looks good to me.
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
Author
|
bors r+ |
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes some tweaks to the SubApp labeling introduced in #2695:
@zicklag (for reference)