Add commands() method to ChildBuilder#2817
Closed
TheNeikos wants to merge 1 commit intobevyengine:mainfrom
Closed
Conversation
TheNeikos
changed the title
TheNeikos
force-pushed
the
feature/add_commands_to_childbuilder
branch
from
d3dffb5 to
310d6be
Compare
Contributor
|
#2448 was a previous PR attempt to add this method. |
Contributor
Author
|
You are right, I'm sorry I should have checked the PRs if someone had tried to do something similar. In my case I have a function that accepts a |
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
S-Needs-Design
Member
|
Closing in favor of #4708. |
bors bot
pushed a commit
that referenced
this pull request
May 17, 2022
# Objective Support returning data out of with_children to enable the use case of changing the parent commands with data created inside the child builder. ## Solution Change the with_children closure to return T. Closes #2817. --- ## Changelog `BuildChildren::add_children` was added with the ability to return data to use outside the closure (for spawning a new child builder on a returned entity for example).
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective Support returning data out of with_children to enable the use case of changing the parent commands with data created inside the child builder. ## Solution Change the with_children closure to return T. Closes bevyengine#2817. --- ## Changelog `BuildChildren::add_children` was added with the ability to return data to use outside the closure (for spawning a new child builder on a returned entity for example).
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Support returning data out of with_children to enable the use case of changing the parent commands with data created inside the child builder. ## Solution Change the with_children closure to return T. Closes bevyengine#2817. --- ## Changelog `BuildChildren::add_children` was added with the ability to return data to use outside the closure (for spawning a new child builder on a returned entity for example).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Commandsstructure while constructing child entitiesSolution
Commandsthrough acommandsmethod onChuildBuilderin a similar fashion toEntityCommands