[Merged by Bors] - Add docstring comment to Style to reference CSS#2936
Closed
djeedai wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add docstring comment to Style to reference CSS#2936djeedai wants to merge 4 commits intobevyengine:mainfrom
djeedai wants to merge 4 commits intobevyengine:mainfrom
Conversation
Mention the fact that the UI layout system is based on the CSS layout model through a docstring comment on the `Style` type.
NiklasEi
added
A-UI
NiklasEi
approved these changes
Oct 8, 2021
Member
|
Added an additional more user-friendly link to help folks navigate things :) Other than that, LGTM, thanks! |
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
alice-i-cecile
approved these changes
Oct 9, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
requested changes
Oct 9, 2021
mockersf
approved these changes
Nov 3, 2021
Contributor
Author
|
Who's doing the final review? Is that only @cart? If so, ping, this is very short to review and ready for merge, thanks! 🙏 |
Member
|
Generally only Cart. @mockersf has merge writes for "uncontroversial" PRs however, which I think this qualifies for. |
Member
|
Yup this is uncontroversial. But I'll merge it because I'm here :) |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2021
Mention the fact that the UI layout system is based on the CSS layout model through a docstring comment on the `Style` type. # Objective Explain to new users that the Bevy UI uses the CSS layout model, to lower the barrier to entry given the fact documentation (book and code) is fairly limited on the topic. ## Solution Fix as discussed with @alice-i-cecile on #2918.
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mention the fact that the UI layout system is based on the CSS layout
model through a docstring comment on the
Styletype.Objective
Explain to new users that the Bevy UI uses the CSS layout model, to lower the barrier to entry given the fact documentation (book and code) is fairly limited on the topic.
Solution
Fix as discussed with @alice-i-cecile on #2918.