[Merged by Bors] - Fix CI for android#2971
Closed
Davier wants to merge 1 commit intobevyengine:pipelined-renderingfrom
Closed
[Merged by Bors] - Fix CI for android#2971Davier wants to merge 1 commit intobevyengine:pipelined-renderingfrom
Davier wants to merge 1 commit intobevyengine:pipelined-renderingfrom
Conversation
alice-i-cecile
added
A-Build-System
Member
|
LGTM. I'm not seeing the CI break on other PRs though; am I missing something? |
Contributor
|
#2653 failed because of this. I assume it's only PR to the pipeline-rendering branch that fail. |
IceSentry
approved these changes
Oct 15, 2021
alice-i-cecile
added
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Oct 15, 2021
mockersf
approved these changes
Oct 15, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 15, 2021
# Objective The update to wgpu 0.11 broke CI for android. This was due to a confusion between `bevy::render::ShaderStage` and `wgpu::ShaderStage`. ## Solution Revert the incorrect change
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The update to wgpu 0.11 broke CI for android. This was due to a confusion between
bevy::render::ShaderStageandwgpu::ShaderStage.Solution
Revert the incorrect change