Closed
Conversation
alice-i-cecile
added
C-Code-Quality
Member
|
related to #2934 |
alice-i-cecile
approved these changes
Oct 25, 2021
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
LGTM. The change to using asserts is a nice lint!
Contributor
Author
Missed that PR as it didn't mention (nightly) clippy in the title. |
Member
|
I'm going to close as a duplicate of #2934; we can consolidate the work over there. |
alice-i-cecile
added
S-Duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Ignored cases
Any Lint that triggered inside the Rendering crates were ignored, as they are about to be replaced by the rendering rework.