[Merged by Bors] - Update derive(DynamicPlugin) to edition 2021#3038
Closed
Iaiao wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Update derive(DynamicPlugin) to edition 2021#3038Iaiao wants to merge 1 commit intobevyengine:mainfrom
Iaiao wants to merge 1 commit intobevyengine:mainfrom
Conversation
DJMcNab
approved these changes
Oct 27, 2021
Member
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
Thanks! I'm interested to hear about how you're using the dynamic plugin.
In particular, I personally think we should probably remove it at present, since it seems quite difficult to use correctly
However, this is purely a win, so I'm in favour of merging this anyway.
DJMcNab
added
C-Bug
alice-i-cecile
approved these changes
Oct 27, 2021
alice-i-cecile
added
S-Ready-For-Final-Review
Contributor
Author
|
I'm rewriting some game server software in bevy, and today I started working on dynamic plugins, so I don't really have much experience using them, but seems like it works, and making it work was way easier than I thought. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
# Objective Edition 2021 requires `dyn Trait` and it won't compile without `dyn`. ## Solution Added `dyn`.
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Edition 2021 requires
dyn Traitand it won't compile withoutdyn.Solution
Added
dyn.