[Merged by Bors] - MSAA example#3049
Closed
superdump wants to merge 4 commits intobevyengine:pipelined-renderingfrom
Closed
[Merged by Bors] - MSAA example#3049superdump wants to merge 4 commits intobevyengine:pipelined-renderingfrom
superdump wants to merge 4 commits intobevyengine:pipelined-renderingfrom
Conversation
superdump
force-pushed
the
msaa-example
branch
from
21fb961 to
f943f75
Compare
superdump
force-pushed
the
msaa-example
branch
from
f943f75 to
a061a25
Compare
inodentry
added
A-Rendering
MinerSebas
reviewed
Oct 31, 2021
IceSentry
approved these changes
Nov 1, 2021
Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
Instead of using a compound condition and assignment, do the assignments within the condition cases. Co-authored-by: MinerSebas <66798382+MinerSebas@users.noreply.github.com>
Member
|
Added a comment about wgpu sample count limitations (copied from our Msaa config docs). This looks good to me! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
Add an example that demonstrates the difference between no MSAA and MSAA 4x. This is also useful for testing panics when resizing the window using MSAA. This is on top of #3042 . Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Member
|
bors crashed for some reason |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 3, 2021
Add an example that demonstrates the difference between no MSAA and MSAA 4x. This is also useful for testing panics when resizing the window using MSAA. This is on top of #3042 . Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an example that demonstrates the difference between no MSAA and MSAA 4x. This is also useful for testing panics when resizing the window using MSAA. This is on top of #3042 .