[Merged by Bors] - explain absence of new constructor in Hash{Map, Set} docs; suggest default#3077
Closed
dataphract wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - explain absence of new constructor in Hash{Map, Set} docs; suggest default#3077dataphract wants to merge 1 commit intobevyengine:mainfrom
new constructor in Hash{Map, Set} docs; suggest default#3077dataphract wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Docs
Member
|
@cart can we get |
alice-i-cecile
approved these changes
Nov 6, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Nov 6, 2021
Member
done! |
Member
|
bors r+ |
Contributor
bors
bot
changed the title
new constructor in Hash{Map, Set} docs; suggest defaultnew constructor in Hash{Map, Set} docs; suggest default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #2823.
Solution
This PR adds notes to the
HashMapandHashSetdocs explaining whyHashMap::new()(resp.HashSet::new()) is not available, and guiding the user toward using theDefaultimplementation for an empty collection.