Fixed ECS example compilation issues#3083
Closed
crener wants to merge 2 commits intobevyengine:mainfrom
crener:main
Closed
Fixed ECS example compilation issues#3083crener wants to merge 2 commits intobevyengine:mainfrom crener:main
crener wants to merge 2 commits intobevyengine:mainfrom
crener:main
Conversation
If you paste the old 'Using Bevy ECS' sample code and try to compile it you will get error messages - system() is not being called for the movement system in the scheduler - The movement systems Query is not mutableable which the rust compiler doesn't like This small commit fixes that so that new users don't have this issue when trying to lean from the samples.
DJMcNab
reviewed
Nov 6, 2021
MinerSebas
reviewed
Nov 6, 2021
| // before moving on to the next Stage | ||
| schedule.add_stage("update", SystemStage::parallel() | ||
| .with_system(movement) | ||
| .with_system(movement.system()) |
Contributor
There was a problem hiding this comment.
With 0.6 (#2398) the usage of .system() is now optional and all examples should no longer contain it.
This change should be reverted.
Member
Noticed that I accidentally changed the use format from 'bevy_ecs' to 'bevy' which seems to be the standard for the crate examples, So reverted that change.
DJMcNab
added
C-Docs
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you paste the old 'Using Bevy ECS' sample code and try to compile it you will get error messages
Fixes compile errors so that new users don't have this issue when trying to lean from the samples.