Closed
Conversation
bjorn3
reviewed
Nov 9, 2021
| @@ -0,0 +1,457 @@ | |||
| //! A copy of "appendlist" crate sources, extended with draining iterator. | |||
Contributor
There was a problem hiding this comment.
Which version? (crates.io version number or commit hash)
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
X-Needs-SME
Contributor
|
WorldCell was removed in #12551, visit the linked PR for the rationale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proof of concept implementation for RFC #42.
Implements runtime-checked ECS queries and commands through shared access to
WorldCellinstance. Those queries see the world as if all queued commands up to their creation point were applied. Every query iterator has its own snapshot of world saved essentially as a diff applied during iteration over the true world data.This PR is currently not feature-complete, but already useful subset of what would have to be implemented. A few commands are missing (mostly bundles support), and the implementation definitely could be improved in many places. But it does serve a purpose of proving that the proposed RFC design is possible to implement, and should be a good starting point for future work.