Skip to content

[Merged by Bors] - Clarify RUST_LOG override over LogSettings#3095

Closed
djeedai wants to merge 1 commit intobevyengine:mainfrom
djeedai:log_settings
Closed

[Merged by Bors] - Clarify RUST_LOG override over LogSettings#3095
djeedai wants to merge 1 commit intobevyengine:mainfrom
djeedai:log_settings

Conversation

@djeedai
Copy link
Contributor

@djeedai djeedai commented Nov 9, 2021

Objective

Clarify the fact that setting the RUST_LOG environment variable
overrides any setting from the LogSettings resource.

Solution

Update docstring comment for LogSettings.

Clarify the fact that setting the `RUST_LOG` environment variable
overrides any setting from the `LogSettings` resource.
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 9, 2021
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation and removed S-Needs-Triage This issue needs to be labelled labels Nov 9, 2021
@alice-i-cecile
Copy link
Member

@cart we're missing a A-Log tag ;)

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 9, 2021
@cart cart added the A-Log label Nov 10, 2021
@cart
Copy link
Member

cart commented Nov 10, 2021

@alice-i-cecile added!

@cart
Copy link
Member

cart commented Nov 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2021
# Objective

Clarify the fact that setting the `RUST_LOG` environment variable
overrides any setting from the `LogSettings` resource.

## Solution

Update docstring comment for `LogSettings`.
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 10, 2021
# Objective

Clarify the fact that setting the `RUST_LOG` environment variable
overrides any setting from the `LogSettings` resource.

## Solution

Update docstring comment for `LogSettings`.
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build failed:

@cart
Copy link
Member

cart commented Nov 11, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 11, 2021
# Objective

Clarify the fact that setting the `RUST_LOG` environment variable
overrides any setting from the `LogSettings` resource.

## Solution

Update docstring comment for `LogSettings`.
@bors bors bot changed the title Clarify RUST_LOG override over LogSettings [Merged by Bors] - Clarify RUST_LOG override over LogSettings Nov 11, 2021
@bors bors bot closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants