[Merged by Bors] - bevy_render2: Support nested shader defs#3113
Closed
superdump wants to merge 3 commits intobevyengine:pipelined-renderingfrom
Closed
[Merged by Bors] - bevy_render2: Support nested shader defs#3113superdump wants to merge 3 commits intobevyengine:pipelined-renderingfrom
superdump wants to merge 3 commits intobevyengine:pipelined-renderingfrom
Conversation
Fixes the case where A is false but B is true in: your code here ...would still produce your code here.
alice-i-cecile
added
A-Rendering
cart
reviewed
Nov 12, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
# Objective Fix nested shader defs. For example, in: ```rust #ifdef A #ifdef B some code here #endif #endif ``` ...before this PR, if `A` *is not* defined, and `B` *is* defined, then `some code here` will be output. ## Solution - Combine the logic of whether the parent and child scope guards are defined and use that as the resulting child scope guard boolean value
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix nested shader defs. For example, in:
...before this PR, if
Ais not defined, andBis defined, thensome code herewill be output.Solution