[Merged by Bors] - add shadows in examples#3201
Closed
mockersf wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - add shadows in examples#3201mockersf wants to merge 2 commits intobevyengine:mainfrom
mockersf wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
added
A-Rendering
Contributor
|
Thanks for doing this. I think also load_gltf_pipelined should have them reenabled. I didn’t check for other possibilities but that one sticks out in my mind. |
Member
Author
|
added in |
alice-i-cecile
approved these changes
Nov 27, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
superdump
approved these changes
Nov 27, 2021
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2021
# Objective - As mentioned in #3126, shadows need to be readded in examples ## Solution - Add shadows in examples
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution