Skip to content

[Merged by Bors] - clearpass: also clear views without depth (2d)#3286

Closed
mockersf wants to merge 1 commit intobevyengine:mainfrom
mockersf:clear-pass-2d
Closed

[Merged by Bors] - clearpass: also clear views without depth (2d)#3286
mockersf wants to merge 1 commit intobevyengine:mainfrom
mockersf:clear-pass-2d

Conversation

@mockersf
Copy link
Member

@mockersf mockersf commented Dec 10, 2021

Objective

Screenshot 2021-12-10 at 00 48 04

Solution

  • Change the query to also work when there isn't a ViewDepthTexture

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 10, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Dec 10, 2021
@alice-i-cecile alice-i-cecile added this to the Bevy 0.6 milestone Dec 10, 2021
@cart
Copy link
Member

cart commented Dec 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 10, 2021
@mockersf
clearpass: also clear views without depth (2d) (#3286)
cf48132 
# Objective

- after #3209, 2d examples background were not cleared

<img width="912" alt="Screenshot 2021-12-10 at 00 48 04" src="https://user-images.githubusercontent.com/8672791/145494415-d4b7a149-6f9a-4036-9ac5-3d1227b4de69.png">

## Solution

- Change the query to also work when there isn't a `ViewDepthTexture`
@bors
Copy link
Contributor

bors bot commented Dec 10, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title clearpass: also clear views without depth (2d) [Merged by Bors] - clearpass: also clear views without depth (2d) Dec 10, 2021
@bors bors bot closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@StarArawn StarArawn StarArawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Projects

None yet

Milestone

Bevy 0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@mockersf @cart @StarArawn @alice-i-cecile