[Merged by Bors] - Fix crash with disabled winit#3330
Closed
Shatur wants to merge 1 commit intobevyengine:mainfrom
gardum-game:disable-winit
Closed
[Merged by Bors] - Fix crash with disabled winit#3330Shatur wants to merge 1 commit intobevyengine:mainfrom gardum-game:disable-winit
Shatur wants to merge 1 commit intobevyengine:mainfrom
gardum-game:disable-winit
Conversation
Member
|
Looks good to me! |
Member
|
you will need to add the new example to the |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 15, 2021
# Objective This PR fixes a crash when winit is enabled when there is a camera in the world. Part of #3155 ## Solution In this PR, I removed two unwraps and added an example for regression testing.
Contributor
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This PR fixes a crash when winit is enabled when there is a camera in the world. Part of #3155
Solution
In this PR, I removed two unwraps and added an example for regression testing.