Closed
Conversation
alice-i-cecile
added
A-Rendering
mockersf
reviewed
Jan 3, 2022
alice-i-cecile
approved these changes
Feb 3, 2022
Weibye
approved these changes
Jul 27, 2022
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
This PR needs to have its merge conflicts resolved. @Davier if you have time please feel free (but I know you've been busy). Otherwise I've added the Adopt-Me label; others are free to remake this PR to fix those. |
This was referenced Aug 3, 2022
Closed
Contributor
|
The issue has already been fixed by #3854, closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #3493.
The issue was that
extracted_uinode.rectis scaled according to the window's scale factor whenextracted_uinode.atlas_sizeisNone, but it's not scaled whenextracted_uinode.atlas_sizeisSome.Solution
I changed one condition to avoid relying on
extracted_uinode.rect, extracted the window's scale factor into the render app, and applied it as necessary when calculating the clipped UVs.To be honest, I can't properly explain why it works this way, and I'm not confident I covered all cases. In #3460, the similar fields
extracted_sprite.rectandextracted_sprite.atlas_sizeare changed to cleanly separate what affects position/size and what affects UVs. I hope to port to UI the sprite improvements of that PR after it's accepted, but meanwhile this smaller PR can fix the issue.