Closed
Conversation
Davier
approved these changes
Jan 5, 2022
Contributor
Davier
left a comment
There was a problem hiding this comment.
I also find that using sort_unstable_by improves performance.
The render items are sorted again in sort_phase_system, but I think that should not become an unstable sort to avoid breaking batches.
The change means that sprites with a depth of NaN may be reordered differently in sort_phase_system, but that's fine by me.
This comment has been minimized.
This comment has been minimized.
a506153 to
ce183ca
Compare
inodentry
suggested changes
Jan 5, 2022
Contributor
inodentry
left a comment
There was a problem hiding this comment.
The logic with the index indirection seems incorrect.
d7a5c75 to
7095163
Compare
Member
Author
|
turns out keeping a smaller index is slower when done without a bug, I removed it |
Member
Author
|
this will change quite a bit with / is already part of #3460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
partial_cmpinstead ofcmpthroughFloatOrdsort_unstable_byinstead ofsort_byresults on my laptop:
partial_cmpsort_unstable_bythe screenshots!
base
partial_cmpsort_unstable_byboth