Skip to content

Fix ANSI colors in chrome and tracy traces#3583

Closed
rparrett wants to merge 1 commit intobevyengine:mainfrom
rparrett:ansi-traces
Closed

Fix ANSI colors in chrome and tracy traces#3583
rparrett wants to merge 1 commit intobevyengine:mainfrom
rparrett:ansi-traces

Conversation

@rparrett
Copy link
Contributor

@rparrett rparrett commented Jan 8, 2022

Objective

Fix ANSI colors in chrome and tracy traces, at the cost of losing ANSI colors in logs to stdout when trace_chrome or trace_tracy features are used.

Note: enabling trace features alters the output logs in other undesirable ways. I think we might need separate subscribers or something to fix that.

Fixes #3563

Solution

Add .with_ansi(false) to the "fmt layer" when trace_chrome or trace_tracy are enabled.

I'd appreciate someone checking the tracy output, as I wasn't able to test that (except to see that bevy still builds with that feature)

At the cost of losing ANSI colors in logs to stdout when
trace_chrome or trace_tracy features are used.
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 8, 2022
@mockersf
Copy link
Member

mockersf commented Jan 8, 2022

ok in tracy
Screenshot 2022-01-08 at 01 33 26

@alice-i-cecile alice-i-cecile added A-Log C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Jan 8, 2022
@rparrett
Copy link
Contributor Author

rparrett commented Jan 8, 2022

Note: adding the trace_chrome or trace_tracy feature also affects logging output to stdout in other ways. This PR doesn't address that. Just removes the ANSI colors so they don't end up in the other traces.

With trace_chrome or trace_tracy:

2022-01-08T00:48:40.761898Z  INFO bevy_app:frame:stage{name=PostUpdate}:prepare_systems:system{name="bevy_diagnostic::log_diagnostics_plugin::LogDiagnosticsPlugin::log_diagnostics_system"}: bevy diagnostic: frame_count                     :   98.000000  (avg 98.000000)

Without:

2022-01-08T00:49:02.431899Z  INFO bevy diagnostic: frame_count                     :   75.000000  (avg 75.000000)

@cart cart added A-Diagnostics Logging, crash handling, error reporting and performance analysis and removed A-Log labels Jun 1, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board; those color symbols are unfortunate.

@rparrett
Copy link
Contributor Author

Closing because I can't reproduce the issue anymore

@rparrett rparrett closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Bug An unexpected or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracing spans include "noisy" characters

4 participants