Fix ANSI colors in chrome and tracy traces#3583
Closed
rparrett wants to merge 1 commit intobevyengine:mainfrom
Closed
Fix ANSI colors in chrome and tracy traces#3583rparrett wants to merge 1 commit intobevyengine:mainfrom
rparrett wants to merge 1 commit intobevyengine:mainfrom
Conversation
At the cost of losing ANSI colors in logs to stdout when trace_chrome or trace_tracy features are used.
Member
Contributor
Author
|
Note: adding the With Without: |
alice-i-cecile
approved these changes
Oct 10, 2022
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
I'm on board; those color symbols are unfortunate.
Contributor
Author
|
Closing because I can't reproduce the issue anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Objective
Fix ANSI colors in chrome and tracy traces, at the cost of losing ANSI colors in logs to stdout when trace_chrome or trace_tracy features are used.
Note: enabling trace features alters the output logs in other undesirable ways. I think we might need separate subscribers or something to fix that.
Fixes #3563
Solution
Add
.with_ansi(false)to the "fmt layer" whentrace_chromeortrace_tracyare enabled.I'd appreciate someone checking the
tracyoutput, as I wasn't able to test that (except to see that bevy still builds with that feature)