[Merged by Bors] - Slight perf improvements and tidy for contributors example

[SUPERCILEX]

No description provided.

[alice-i-cecile]

I generally really like these changes! They clean things up a bit, and are well-motivated. In real code, I would probably prefer the for_each pattern for perf, but the for loop is easier to read for beginners (and Cart has asked us to use that style in examples).

[SUPERCILEX]

@alice-i-cecile Is there anything I need to do after the approval?

[alice-i-cecile]

@alice-i-cecile Is there anything I need to do after the approval?

Nope, you're all good. If you'd like, you can ask around and wrangle up another approval from the community. Once that's in place, I can merge this in.

(I have merge rights for docs and examples).

[SUPERCILEX]

Makes sense, thanks!

[rparrett]

While we're at it, it would be a bit more idiomatic for that timer to be a resource rather than a component.

[SUPERCILEX]

@rparrett Like this? 52d57fa

[rparrett]

@rparrett Like this? 52d57fa

That looks a lot nicer!

[alice-i-cecile]

I like the further changes! A bit iffy on the clippy ignore, but I agree that it's a clippy bug.

[SUPERCILEX]

@alice-i-cecile @rparrett Looks like this should finally be ready for a merge. Any outstanding concerns?

[rparrett]

Just a nit, but a few other examples (plugin, font_atlas_debug) use a naming scheme that would look like

struct SelectionState {
    timer: Timer,
    has_triggered: bool,
}

When combining a timer with some other state in a resource.

[SUPERCILEX]

Sounds good, done!

[rparrett]

This changeset seems like an improvement to me. I tested with an artificially shortened contributor list to ensure that the wrapping still works.

[alice-i-cecile]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• check-benches
• check-doc
• check-markdown-links
• check-missing-examples-in-docs
• check-unused-dependencies
• ci
• markdownlint
• miri
• run-examples

[SUPERCILEX]

Woohoo, thanks!