[Merged by Bors] - add more logs when despawning entities#3851
Closed
mockersf wants to merge 5 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - add more logs when despawning entities#3851mockersf wants to merge 5 commits intobevyengine:mainfrom
mockersf wants to merge 5 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
Member
|
Member
Author
If the two PRs are merged, I'll update the error message for discovery, and add an error code, and ... |
mockersf
force-pushed
the
log-span-despawn
branch
from
b9a0349 to
0cb2a0a
Compare
mockersf
force-pushed
the
log-span-despawn
branch
from
0cb2a0a to
c9cb49e
Compare
mockersf
force-pushed
the
log-span-despawn
branch
from
c9cb49e to
df07b61
Compare
alice-i-cecile
approved these changes
Mar 19, 2022
IceSentry
approved these changes
Apr 13, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
IceSentry
reviewed
Apr 13, 2022
alice-i-cecile
added
the
M-Migration-Guide
mockersf
removed
the
M-Migration-Guide
Member
Author
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
# Objective
- Provide more information when despawning an entity
## Solution
- Add a debug log when despawning an entity
- Add spans to the recursive ways of despawning an entity
```sh
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0
```
Contributor
bors
bot
changed the title
| keywords = ["bevy"] | ||
|
|
||
| [features] | ||
| trace = [] |
Contributor
There was a problem hiding this comment.
Oops, this must be some case of auto-merge failure. The feature should be on bevy_hierarchy.
mockersf
added a commit
to mockersf/bevy
that referenced
this pull request
Apr 14, 2022
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective
- Provide more information when despawning an entity
## Solution
- Add a debug log when despawning an entity
- Add spans to the recursive ways of despawning an entity
```sh
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0
```
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - in bevyengine#3851, a feature for tracing was added to bevy_transform - usage of that feature was moved to bevy_hierarchy, but the feature was not updated ## Solution - add the feature to bevy_hierarchy, remove it from bevy_transform
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective
- Provide more information when despawning an entity
## Solution
- Add a debug log when despawning an entity
- Add spans to the recursive ways of despawning an entity
```sh
RUST_LOG=debug cargo run --example panic --features trace
# RUST_LOG=debug needed to show debug logs from bevy_ecs
# --features trace needed to have the extra spans
...
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 1v0
DEBUG bevy_app:frame:stage{name=Update}:system_commands{name="panic::despawn_parent"}:command{name="DespawnRecursive" entity=0v0}: bevy_ecs::world: Despawning entity 0v0
```
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - in bevyengine#3851, a feature for tracing was added to bevy_transform - usage of that feature was moved to bevy_hierarchy, but the feature was not updated ## Solution - add the feature to bevy_hierarchy, remove it from bevy_transform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution