change system name of RunSystem to system type name, not param type name#3935
Closed
jakobhellermann wants to merge 1 commit intobevyengine:mainfrom
Closed
change system name of RunSystem to system type name, not param type name#3935jakobhellermann wants to merge 1 commit intobevyengine:mainfrom
RunSystem to system type name, not param type name#3935jakobhellermann wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
alice-i-cecile
approved these changes
Feb 13, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Well-motivated, code checks out. I like this.
mockersf
approved these changes
Feb 14, 2022
mockersf
added
the
S-Ready-For-Final-Review
Member
What would the span looks like without the |
Member
|
Whatever the span looks like with a function system, which I don't have to hand? |
Contributor
Author
|
Since #3817 is now merged, this can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools like bevy_mod_debugdump use the system name to visualize the schedule.
Previously, the system name of
RunSystems would have the type name of their system param as their system name, so for example thePrepareAssetSystem<StandardMaterial>was called(ResMut<ExtractedAssets<StandardMaterial>>, ResMut<HashMap<Handle<StandardMaterial>, GpuStandardMaterial, RandomState>>, ResMut<PrepareNextFrameAssets<StandardMaterial>>, (Res<RenderDevice>, Res<MaterialPipeline<StandardMaterial>>, Res<HashMap<Handle<Image>, GpuImage, RandomState>>)).This PR uses the name of the type implementing
RunSystemas system name, so the new name isPrepareAssetSystem<StandardMaterial>.Before:
After: