[Merged by Bors] - Add more FromWorld implementations#3945
Closed
TheRawMeatball wants to merge 5 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Add more FromWorld implementations#3945TheRawMeatball wants to merge 5 commits intobevyengine:mainfrom
TheRawMeatball wants to merge 5 commits intobevyengine:mainfrom
Conversation
TheRawMeatball
added
A-ECS
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Very interesting. This PR's code quality and docs are fine. The future work sounds promising and this LGTM, but I wouldn't merge until we have something useful built on top of this (just fork off of this PR IMO).
cart
reviewed
Apr 1, 2022
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
This is a win! Love the idea. Maybe we should do the same for QueryState?
Member
I like this, I think. |
alice-i-cecile
approved these changes
Apr 5, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
# Objective
Make `FromWorld` more useful for abstractions with a form similar to
```rs
trait FancyAbstraction {
type PreInitializedData: FromWorld;
}
```
## Solution
Add a `FromWorld` implementation for `SystemState` as well as a way to group together multiple `FromWorld` implementing types as one.
Note: I plan to follow up this PR with another to add `Local` support to exclusive systems, which should get a fair amount of use from the `FromWorld` implementation on `SystemState`.
Contributor
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective
Make `FromWorld` more useful for abstractions with a form similar to
```rs
trait FancyAbstraction {
type PreInitializedData: FromWorld;
}
```
## Solution
Add a `FromWorld` implementation for `SystemState` as well as a way to group together multiple `FromWorld` implementing types as one.
Note: I plan to follow up this PR with another to add `Local` support to exclusive systems, which should get a fair amount of use from the `FromWorld` implementation on `SystemState`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective
Make `FromWorld` more useful for abstractions with a form similar to
```rs
trait FancyAbstraction {
type PreInitializedData: FromWorld;
}
```
## Solution
Add a `FromWorld` implementation for `SystemState` as well as a way to group together multiple `FromWorld` implementing types as one.
Note: I plan to follow up this PR with another to add `Local` support to exclusive systems, which should get a fair amount of use from the `FromWorld` implementation on `SystemState`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Make
FromWorldmore useful for abstractions with a form similar toSolution
Add a
FromWorldimplementation forSystemStateas well as a way to group together multipleFromWorldimplementing types as one.Note: I plan to follow up this PR with another to add
Localsupport to exclusive systems, which should get a fair amount of use from theFromWorldimplementation onSystemState.