Skip to content

Shader passthrough alternative #3997

Closed
molikto wants to merge 2 commits intobevyengine:mainfrom
molikto:spirv-shader-passthrough-alt
Closed

Shader passthrough alternative #3997
molikto wants to merge 2 commits intobevyengine:mainfrom
molikto:spirv-shader-passthrough-alt

Conversation

@molikto
Copy link
Contributor

@molikto molikto commented Feb 20, 2022

Objective

Enable wgpu spirv-shader-passthrough.

Solution

if has wgpu::Features::SPIRV_SHADER_PASSTHROUGH, always load spirv shaders using the pass through. This is kind of a abuse of wgpu API, but I like it because the change is minimal to bevy, and it doesn't add extra features to bevy. I think this is a sensible default, and I don't want to build elaborate features without people actually finding this sensible default undesirable

alternative to #3996

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 20, 2022
@molikto molikto mentioned this pull request Feb 20, 2022
@james7132 james7132 added A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible and removed S-Needs-Triage This issue needs to be labelled labels Feb 21, 2022
@molikto molikto closed this Mar 9, 2022
@molikto molikto deleted the spirv-shader-passthrough-alt branch May 17, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants