Conversation
# Conflicts: # crates/bevy_render/src/lib.rs # crates/bevy_render/src/renderer/mod.rs # crates/bevy_render/src/settings.rs
|
@superdump already worked, or is working, on some kind of integration, here https://github.com/superdump/bevy/tree/wgpu-timestamp-queries . I guess you two should link up 🙂 |
james7132
added
A-Rendering
|
|
||
| let features = wgpu::Features::TEXTURE_ADAPTER_SPECIFIC_FORMAT_FEATURES; | ||
| #[cfg(feature = "gpu_profiler")] | ||
| let features = features | wgpu::Features::TIMESTAMP_QUERY; |
There was a problem hiding this comment.
I think this will fail on platforms that don't support timestamp queries. I don't know if I think that should be the preferred behaviour rather than silently not working.
|
Mmm, maybe we can try to merge the two somehow. I think using diagnostics makes sense for making the measurements available for printing or so. And I think using the |
I think this PR is definitely not well designed, partly because I am not familiar with graphics APIs, so go ahead the way you want! On the other hand, the profiler is only enabled in debug/dev builds, so I don't know how well designed it should be |
Veloren enables it in release builds too. It has an option in the graphics settings. |
|
What's the progress on this PR? Seems dead but is it worth reviving? |
|
would that allow us to know how much drawcall we're doing per frame ? that would be really good info 🙏 |
|
Looks like this was covered by #9135. Will close this at the end of the week unless someone objects. |
|
No objections, closing as implemented. |
8 participants
Objective
Enable GPU profile each render passes.
Solution
integrate https://github.com/Wumpf/wgpu-profiler, user can enable the render pass profiling individually, and the result will be written to a diagnostics (not sure if this is the best thing to do)
I tried to integrate this as a external plugin without success, also the code is really bad, so just a WIP/pitch