[Merged by Bors] - Fixed Android example icon#4076
Closed
ManevilleF wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Fixed Android example icon#4076ManevilleF wants to merge 1 commit intobevyengine:mainfrom
ManevilleF wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
Author
|
Note that the example still crashes, this only fixes the icon |
mockersf
added
O-Android
alice-i-cecile
approved these changes
Mar 4, 2022
Contributor
Author
|
@alice-i-cecile Going through my open PRs I think this can be merged |
Member
Can you link this to me? Having a bit of trouble finding it. Once that's done I'm happy to merge this as trivial. |
Contributor
Author
mockersf
reviewed
Jun 24, 2022
ManevilleF
force-pushed
the
feat/fix_android_example_icon
branch
from
ea30353 to
a69fafe
Compare
Contributor
Author
|
Rebased on main and applied review comments |
mockersf
approved these changes
Jun 24, 2022
mockersf
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
# Objective - The android example icon doesn't show up ## Solution - I fixed the android metadata to match `cargo-apk` manifest
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - The android example icon doesn't show up ## Solution - I fixed the android metadata to match `cargo-apk` manifest
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - The android example icon doesn't show up ## Solution - I fixed the android metadata to match `cargo-apk` manifest
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - The android example icon doesn't show up ## Solution - I fixed the android metadata to match `cargo-apk` manifest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
cargo-apkmanifest