Heritable trait based property inheritance systems#4216
Closed
james7132 wants to merge 5 commits intobevyengine:mainfrom
Closed
Heritable trait based property inheritance systems#4216james7132 wants to merge 5 commits intobevyengine:mainfrom
james7132 wants to merge 5 commits intobevyengine:mainfrom
Conversation
Contributor
|
‘Heritable’ is an odd word to me. I would have expected ‘Inheritable’. However, I feel like ‘Hierarchical’ or ‘Hierarchic’ might be a better fit semantically. Hmm. |
superdump
reviewed
Mar 16, 2022
Member
Author
Seems pretty apt to me. |
Contributor
|
I'll throw in 'Hereditary' for good measure 😂 Heritable and inheritable are synonyms, a bit like flammable and inflammable. Personally I would err on the side of 'inheritable' because it's far more common. |
This was referenced Jun 2, 2022
Closed
2 tasks
Contributor
|
Closing as part of backlog cleanup: inactivity, no clear consensus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
First/naive attempt to generalize
transform_propagate_systemfor any inheritable component.Solution
Heritabletrait that defines the inheritance behavior across a hierarchy.GlobalTransformimplements this trait.transform_propagate_systemusingHeritableas generic systems.Appfor inserting these systems into the schedule.This implementation includes the optimizations found in #4180.
There are a few drawbacks to this naive approach (originally detailed here: #4213 (reply in thread))
Followup Work
Implement this for
VisibilityandComputedVisibility. Will likely need to work with existing systems for computed visibility in some way.