[Merged by Bors] - Move Rect to bevy_ui and rename it to UiRect#4276
Conversation
ghost
added
A-Accessibility
alice-i-cecile
approved these changes
Mar 21, 2022
ghost
mentioned this pull request
mockersf
approved these changes
Mar 21, 2022
ghost
mentioned this pull request
alice-i-cecile
added
the
S-Ready-For-Final-Review
pubrrr
reviewed
Mar 23, 2022
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
# Objective - Closes #335. - Part of the splitting process of #3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in #4276) - Discussion in #3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
# Objective - Related #4276. - Part of the splitting process of #3503. ## Solution - Move `Size` to `bevy_ui`. ## Reasons - `Size` is only needed in `bevy_ui` (because it needs to use `Val` instead of `f32`), but it's also used as a worse `Vec2` replacement in other areas. - `Vec2` is more powerful than `Size` so it should be used whenever possible. - Discussion in #3503. ## Changelog ### Changed - The `Size` type got moved from `bevy_math` to `bevy_ui`. ## Migration Guide - The `Size` type got moved from `bevy::math` to `bevy::ui`. To migrate you just have to import `bevy::ui::Size` instead of `bevy::math::Math` or use the `bevy::prelude` instead. Co-authored-by: KDecay <KDecayMusic@protonmail.com>
Member
|
bors r+ |
Contributor
|
Merge conflict. |
Member
|
@KDecay can you rebase? |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
# Objective - Closes #335. - Related #4285. - Part of the splitting process of #3503. ## Solution - Move `Rect` to `bevy_ui` and rename it to `UiRect`. ## Reasons - `Rect` is only used in `bevy_ui` and therefore calling it `UiRect` makes the intent clearer. - We have two types that are called `Rect` currently and it's missleading (see `bevy_sprite::Rect` and #335). - Discussion in #3503. ## Changelog ### Changed - The `Rect` type got moved from `bevy_math` to `bevy_ui` and renamed to `UiRect`. ## Migration Guide - The `Rect` type got renamed to `UiRect`. To migrate you just have to change every occurrence of `Rect` to `UiRect`. Co-authored-by: KDecay <KDecayMusic@protonmail.com>
Contributor
bors
bot
changed the title
Rect to bevy_ui and rename it to UiRectRect to bevy_ui and rename it to UiRect
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Related bevyengine#4276. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Size` to `bevy_ui`. ## Reasons - `Size` is only needed in `bevy_ui` (because it needs to use `Val` instead of `f32`), but it's also used as a worse `Vec2` replacement in other areas. - `Vec2` is more powerful than `Size` so it should be used whenever possible. - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Size` type got moved from `bevy_math` to `bevy_ui`. ## Migration Guide - The `Size` type got moved from `bevy::math` to `bevy::ui`. To migrate you just have to import `bevy::ui::Size` instead of `bevy::math::Math` or use the `bevy::prelude` instead. Co-authored-by: KDecay <KDecayMusic@protonmail.com>
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Closes bevyengine#335. - Related bevyengine#4285. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Rect` to `bevy_ui` and rename it to `UiRect`. ## Reasons - `Rect` is only used in `bevy_ui` and therefore calling it `UiRect` makes the intent clearer. - We have two types that are called `Rect` currently and it's missleading (see `bevy_sprite::Rect` and bevyengine#335). - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Rect` type got moved from `bevy_math` to `bevy_ui` and renamed to `UiRect`. ## Migration Guide - The `Rect` type got renamed to `UiRect`. To migrate you just have to change every occurrence of `Rect` to `UiRect`. Co-authored-by: KDecay <KDecayMusic@protonmail.com>
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Closes bevyengine#335. - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in bevyengine#4276) - Discussion in bevyengine#3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.
ghost
deleted the
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Closes bevyengine#335. - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `margins.rs` file containing the `Margins` type. ## Reasons - It is unused inside of `bevy`. - The `Rect`/`UiRect` is identical to the `Margins` type and is also used for margins inside of `bevy` (rename of `Rect` happens in bevyengine#4276) - Discussion in bevyengine#3503. ## Changelog ### Removed - The `Margins` type got removed. ## Migration Guide - The `Margins` type got removed. To migrate you just have to change every occurrence of `Margins` to `UiRect`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Related bevyengine#4276. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Size` to `bevy_ui`. ## Reasons - `Size` is only needed in `bevy_ui` (because it needs to use `Val` instead of `f32`), but it's also used as a worse `Vec2` replacement in other areas. - `Vec2` is more powerful than `Size` so it should be used whenever possible. - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Size` type got moved from `bevy_math` to `bevy_ui`. ## Migration Guide - The `Size` type got moved from `bevy::math` to `bevy::ui`. To migrate you just have to import `bevy::ui::Size` instead of `bevy::math::Math` or use the `bevy::prelude` instead. Co-authored-by: KDecay <KDecayMusic@protonmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Closes bevyengine#335. - Related bevyengine#4285. - Part of the splitting process of bevyengine#3503. ## Solution - Move `Rect` to `bevy_ui` and rename it to `UiRect`. ## Reasons - `Rect` is only used in `bevy_ui` and therefore calling it `UiRect` makes the intent clearer. - We have two types that are called `Rect` currently and it's missleading (see `bevy_sprite::Rect` and bevyengine#335). - Discussion in bevyengine#3503. ## Changelog ### Changed - The `Rect` type got moved from `bevy_math` to `bevy_ui` and renamed to `UiRect`. ## Migration Guide - The `Rect` type got renamed to `UiRect`. To migrate you just have to change every occurrence of `Rect` to `UiRect`. Co-authored-by: KDecay <KDecayMusic@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Sizetobevy_ui#4285.Solution
Recttobevy_uiand rename it toUiRect.Reasons
Rectis only used inbevy_uiand therefore calling itUiRectmakes the intent clearer.Rectcurrently and it's missleading (seebevy_sprite::Rectand bevy_sprite::Rect is not the same as bevy_math::Rect #335).Changelog
Changed
Recttype got moved frombevy_mathtobevy_uiand renamed toUiRect.Migration Guide
Recttype got renamed toUiRect. To migrate you just have to change every occurrence ofRecttoUiRect.