[Merged by Bors] - Remove face_toward.rs#4277
Closed
Conversation
ghost
added
A-Math
alice-i-cecile
approved these changes
Mar 21, 2022
james7132
approved these changes
Mar 21, 2022
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 21, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 3, 2022
# Objective - Part of the splitting process of #3503. ## Solution - Remove the `face_toward.rs` file containing the `FaceToward` trait. ## Reasons - It is unused inside of `bevy`. - The method `Mat4::face_toward` of the trait is identical to `Mat4::look_at_rh` (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh). - Discussion in #3503. ## Changelog ### Removed - The `FaceToward` trait got removed. ## Migration Guide - The `FaceToward` trait got removed. To migrate you just have to change every occurrence of `Mat4::face_toward` to `Mat4::look_at_rh`.
Contributor
bors
bot
changed the title
face_toward.rsface_toward.rs
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `face_toward.rs` file containing the `FaceToward` trait. ## Reasons - It is unused inside of `bevy`. - The method `Mat4::face_toward` of the trait is identical to `Mat4::look_at_rh` (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh). - Discussion in bevyengine#3503. ## Changelog ### Removed - The `FaceToward` trait got removed. ## Migration Guide - The `FaceToward` trait got removed. To migrate you just have to change every occurrence of `Mat4::face_toward` to `Mat4::look_at_rh`.
ghost
deleted the
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Part of the splitting process of bevyengine#3503. ## Solution - Remove the `face_toward.rs` file containing the `FaceToward` trait. ## Reasons - It is unused inside of `bevy`. - The method `Mat4::face_toward` of the trait is identical to `Mat4::look_at_rh` (see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh). - Discussion in bevyengine#3503. ## Changelog ### Removed - The `FaceToward` trait got removed. ## Migration Guide - The `FaceToward` trait got removed. To migrate you just have to change every occurrence of `Mat4::face_toward` to `Mat4::look_at_rh`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
face_toward.rsfile containing theFaceTowardtrait.Reasons
bevy.Mat4::face_towardof the trait is identical toMat4::look_at_rh(see https://docs.rs/glam/latest/glam/f32/struct.Mat4.html#method.look_at_rh).Changelog
Removed
FaceTowardtrait got removed.Migration Guide
FaceTowardtrait got removed. To migrate you just have to change every occurrence ofMat4::face_towardtoMat4::look_at_rh.