Skip to content

[Merged by Bors] - Group stress test examples#4289

Closed
alice-i-cecile wants to merge 7 commits intobevyengine:mainfrom
alice-i-cecile:stress-tests
Closed

[Merged by Bors] - Group stress test examples#4289
alice-i-cecile wants to merge 7 commits intobevyengine:mainfrom
alice-i-cecile:stress-tests

Conversation

@alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Mar 21, 2022 •
edited
Loading

Objective

  • Several examples are useful for qualitative tests of Bevy's performance
  • By contrast, these are less useful for learning material: they are often relatively complex and have large amounts of setup and are performance optimized.

Solution

  • Move bevymark, many_sprites and many_cubes into the new stress_tests example folder
  • Move contributors into the games folder: unlike the remaining examples in the 2d folder, it is not focused on demonstrating a clear feature.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples labels Mar 21, 2022
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 21, 2022
@alice-i-cecile alice-i-cecile added A-Meta About the project itself and removed S-Needs-Triage This issue needs to be labelled C-Docs An addition or correction to our documentation labels Mar 21, 2022
@rparrett rparrett mentioned this pull request Mar 22, 2022
Closed
IceSentry
IceSentry approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried to do almost the exact same thing in another PR. LGTM

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 10, 2022
@alice-i-cecile
Copy link
Member Author

alice-i-cecile commented Apr 10, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 10, 2022
@alice-i-cecile
Group stress test examples (#4289)
147c7c3 
# Objective

- Several examples are useful for qualitative tests of Bevy's performance
- By contrast, these are less useful for learning material: they are often relatively complex and have large amounts of setup and are performance optimized.

## Solution

- Move bevymark, many_sprites and many_cubes into the new stress_tests example folder
- Move contributors into the games folder: unlike the remaining examples in the 2d folder, it is not focused on demonstrating a clear feature.
@bors
Copy link
Contributor

bors bot commented Apr 10, 2022

Build failed:

@alice-i-cecile
Copy link
Member Author

alice-i-cecile commented Apr 10, 2022

bors retry

bors bot pushed a commit that referenced this pull request Apr 10, 2022
@alice-i-cecile
Group stress test examples (#4289)
c747cc5 
# Objective

- Several examples are useful for qualitative tests of Bevy's performance
- By contrast, these are less useful for learning material: they are often relatively complex and have large amounts of setup and are performance optimized.

## Solution

- Move bevymark, many_sprites and many_cubes into the new stress_tests example folder
- Move contributors into the games folder: unlike the remaining examples in the 2d folder, it is not focused on demonstrating a clear feature.
@bors
Copy link
Contributor

bors bot commented Apr 10, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Group stress test examples [Merged by Bors] - Group stress test examples Apr 10, 2022
@bors bors bot closed this Apr 10, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@alice-i-cecile @aevyrie
Group stress test examples (bevyengine#4289)
0affd3a 
# Objective

- Several examples are useful for qualitative tests of Bevy's performance
- By contrast, these are less useful for learning material: they are often relatively complex and have large amounts of setup and are performance optimized.

## Solution

- Move bevymark, many_sprites and many_cubes into the new stress_tests example folder
- Move contributors into the games folder: unlike the remaining examples in the 2d folder, it is not focused on demonstrating a clear feature.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @ItsDoot
Group stress test examples (bevyengine#4289)
d4a74ee 
# Objective

- Several examples are useful for qualitative tests of Bevy's performance
- By contrast, these are less useful for learning material: they are often relatively complex and have large amounts of setup and are performance optimized.

## Solution

- Move bevymark, many_sprites and many_cubes into the new stress_tests example folder
- Move contributors into the games folder: unlike the remaining examples in the 2d folder, it is not focused on demonstrating a clear feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james7132 james7132 james7132 approved these changes

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Meta About the project itself C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alice-i-cecile @james7132 @IceSentry