[Merged by Bors] - Fix gamepad connection system ordering#4313
Conversation
ghost
added
C-Bug
alice-i-cecile
approved these changes
Mar 24, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I agree with this logic; it's nice to stamp out one more obviously incorrect system order ambiguity.
ghost
changed the title
bevy_input: Fix gamepad connection system ordering
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 29, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
# Objective - Part of the splitting process of #3692. ## Solution - Change the `gamepad_connection_system` to run after the `InputSystem` label. ## Reasons I changed the `gamepad_connection_system` to run after the `InputSystem` instead of in parallel, because this system checks the `GamepadEvent`s which get send inside of the `gamepad_event_system`. This means that the `gamepad_connection_system` could respond to the events one frame later, instead of instantly resulting in one frame lag. Old possible case: 1. `gamepad_connection_system` (reacts to the `GamepadEvent`s too early) 2. `gamepad_event_system` (sends the `GamepadEvent`s) New fixed ordering: 1. `gamepad_event_system` (sends the `GamepadEvent`s) 2. `gamepad_connection_system` (reacts to the `GamepadEvent`s)
Contributor
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Part of the splitting process of bevyengine#3692. ## Solution - Change the `gamepad_connection_system` to run after the `InputSystem` label. ## Reasons I changed the `gamepad_connection_system` to run after the `InputSystem` instead of in parallel, because this system checks the `GamepadEvent`s which get send inside of the `gamepad_event_system`. This means that the `gamepad_connection_system` could respond to the events one frame later, instead of instantly resulting in one frame lag. Old possible case: 1. `gamepad_connection_system` (reacts to the `GamepadEvent`s too early) 2. `gamepad_event_system` (sends the `GamepadEvent`s) New fixed ordering: 1. `gamepad_event_system` (sends the `GamepadEvent`s) 2. `gamepad_connection_system` (reacts to the `GamepadEvent`s)
ghost
deleted the
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Part of the splitting process of bevyengine#3692. ## Solution - Change the `gamepad_connection_system` to run after the `InputSystem` label. ## Reasons I changed the `gamepad_connection_system` to run after the `InputSystem` instead of in parallel, because this system checks the `GamepadEvent`s which get send inside of the `gamepad_event_system`. This means that the `gamepad_connection_system` could respond to the events one frame later, instead of instantly resulting in one frame lag. Old possible case: 1. `gamepad_connection_system` (reacts to the `GamepadEvent`s too early) 2. `gamepad_event_system` (sends the `GamepadEvent`s) New fixed ordering: 1. `gamepad_event_system` (sends the `GamepadEvent`s) 2. `gamepad_connection_system` (reacts to the `GamepadEvent`s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_input#3692.Solution
gamepad_connection_systemto run after theInputSystemlabel.Reasons
I changed the
gamepad_connection_systemto run after theInputSysteminstead of in parallel, because this system checks theGamepadEvents which get send inside of thegamepad_event_system. This means that thegamepad_connection_systemcould respond to the events one frame later, instead of instantly resulting in one frame lag.Old possible case:
gamepad_connection_system(reacts to theGamepadEvents too early)gamepad_event_system(sends theGamepadEvents)New fixed ordering:
gamepad_event_system(sends theGamepadEvents)gamepad_connection_system(reacts to theGamepadEvents)