[Merged by Bors] - bevy_input: Fix process touch event by light4 · Pull Request #4352 · bevyengine/bevy

light4 · 2022-03-28T10:07:28Z

Objective

process_touch_event in bevy_input don't update position info. TouchPhase::Ended and TouchPhase::Cancelled should use the position info from pressed. Otherwise, it'll not update. The position info is updated from TouchPhase::Moved.

Solution

Use updated touch info.

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, feel free to skip this section.

Fixed: bevy_input, fix process touch event, update touch info

MrGVSV · 2022-03-28T16:08:23Z

crates/bevy_input/src/touch.rs

-                self.just_released.insert(event.id, event.into());
-                self.pressed.remove_entry(&event.id);
+                if let Some((_, v)) = self.pressed.remove_entry(&event.id) {
+                    self.just_released.insert(event.id, v);


Shouldn't we update the touch phase before inserting? (Same on canceled)

The touch info is from self.pressed or event, so I think this is fine.
I can change this if you prefer to update it first.

Actually, the touch info should come from self.pressed.
If not found in self.pressed, there may be some error occurred, set it to default just to get rid of panic.

The touch info is from self.pressed or event, so I think this is fine.

You mean it already reflects the Ended/Canceled phase? I haven't used touches in Bevy before but I assume the event returned from just_released would be one of those phases.

The info is updated from phase TouchPhase::Moved

Oh interesting. See I'd think that one should also update the phase to Moved. 🤔

But maybe I'm just mistaken in how the touch system is supposed to work.

alice-i-cecile · 2022-03-29T03:24:04Z

Requesting review from @HackerFoo, who has by far the most practical experience with Bevy's touch APIs.

HackerFoo

I couldn't understand the PR description. It would be good to update this to make this easier for other reviewers.

From looking at the code and test, it looks like this makes sure .position/.force gets moved to .prev_position/.prev_force for TouchPhase::Ended (the last update in a motion) as it is in other phases. Before this change, the current position would be assigned to both in this phase.

So this change makes sense and is useful to get a correct delta on the last update.

HackerFoo · 2022-03-29T21:16:37Z

crates/bevy_input/src/touch.rs

        assert!(touches.just_released.get(&touch_event.id).is_some());
        assert!(touches.pressed.get(&touch_event.id).is_none());
+        let touch = touches.just_released.get(&touch_event.id).unwrap();
+        assert!(touch.previous_position != touch.position);


It would be good to add an explanation for this assertion.

alice-i-cecile

If you're around, could you try to improve the PR description and add comments to the if let blocks added? This change is correct, and I won't block on it, but it would be nice to clean it up as we go.

I'll merge this once that's done or next Monday.

`TouchPhase::Ended` and `TouchPhase::Cancelled` should use the position info from `pressed`. Otherwise, it'll not update. The position info is updated from `TouchPhase::Moved`.

light4 · 2022-10-10T17:36:37Z

Rebased and add comments to if let blocks.
Sorry, I'm not a native English speaker. It'll be great if you can help me to improve the description.

alice-i-cecile · 2022-10-10T17:42:53Z

Thanks a ton, and no worries :)

process_touch_event in bevy_input don't update position info. TouchPhase::Ended and TouchPhase::Cancelled should use the position info from pressed. Otherwise, it'll not update. The position info is updated from TouchPhase::Moved.

This is actually quite good now! Thank you very much.

bors r+

# Objective - `process_touch_event` in `bevy_input` don't update position info. `TouchPhase::Ended` and `TouchPhase::Cancelled` should use the position info from `pressed`. Otherwise, it'll not update. The position info is updated from `TouchPhase::Moved`. ## Solution - Use updated touch info. --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, feel free to skip this section. - Fixed: bevy_input, fix process touch event, update touch info

bors · 2022-10-10T17:57:11Z

Pull request successfully merged into main.

Build succeeded:

# Objective - `process_touch_event` in `bevy_input` don't update position info. `TouchPhase::Ended` and `TouchPhase::Cancelled` should use the position info from `pressed`. Otherwise, it'll not update. The position info is updated from `TouchPhase::Moved`. ## Solution - Use updated touch info. --- ## Changelog > This section is optional. If this was a trivial fix, or has no externally-visible impact, feel free to skip this section. - Fixed: bevy_input, fix process touch event, update touch info

github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 28, 2022

MrGVSV reviewed Mar 28, 2022

View reviewed changes

IceSentry added A-Input Player input via keyboard, mouse, gamepad, and more and removed S-Needs-Triage This issue needs to be labelled labels Mar 28, 2022

alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Mar 28, 2022

alice-i-cecile requested a review from HackerFoo March 29, 2022 03:23

HackerFoo approved these changes Mar 29, 2022

View reviewed changes

HackerFoo reviewed Mar 29, 2022

View reviewed changes

light4 force-pushed the fix_process_touch_event branch 2 times, most recently from dfeaa8d to 166fd50 Compare March 30, 2022 04:43

Weibye mentioned this pull request Jun 12, 2022

[Merged by Bors] - Fixed bevy_ui touch input #4099

Closed

alice-i-cecile approved these changes Oct 10, 2022

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 10, 2022

light4 force-pushed the fix_process_touch_event branch 4 times, most recently from df24196 to 52856a8 Compare October 10, 2022 17:28

bevy_input: Fix process touch event

b47cddb

`TouchPhase::Ended` and `TouchPhase::Cancelled` should use the position info from `pressed`. Otherwise, it'll not update. The position info is updated from `TouchPhase::Moved`.

light4 force-pushed the fix_process_touch_event branch from 52856a8 to b47cddb Compare October 10, 2022 17:33

bors bot changed the title ~~bevy_input: Fix process touch event~~ [Merged by Bors] - bevy_input: Fix process touch event Oct 10, 2022

bors bot closed this Oct 10, 2022

light4 deleted the fix_process_touch_event branch October 10, 2022 17:58

Uh oh!

Conversation

light4 commented Mar 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Changelog

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile commented Mar 29, 2022

Uh oh!

HackerFoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

light4 commented Oct 10, 2022

Uh oh!

alice-i-cecile commented Oct 10, 2022

Uh oh!

bors bot commented Oct 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

light4 commented Mar 28, 2022 •

edited

Loading

alice-i-cecile left a comment •

edited

Loading