Skip to content

run skinned shadow wireframe example in ci#4370

Closed
mockersf wants to merge 2 commits intobevyengine:mainfrom
mockersf:skinned-shadow-wireframe-in-ci
Closed

run skinned shadow wireframe example in ci#4370
mockersf wants to merge 2 commits intobevyengine:mainfrom
mockersf:skinned-shadow-wireframe-in-ci

Conversation

@mockersf
Copy link
Member

Objective

  • Avoid regressions on skinned mesh with shadow and wireframe

Solution

  • Run an example in CI

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 30, 2022
@cart
Copy link
Member

cart commented Mar 30, 2022

This feels like its adding "noise" to our examples. We already have examples that illustrate these features individually, and I don't think we should treat examples as "regression tests", especially given that this will only protect us against future crashes (not actual "correctness" of these features working together).

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-Build-System Related to build systems or continuous integration C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples and removed S-Needs-Triage This issue needs to be labelled C-Code-Quality A section of code that is hard to understand or change labels Mar 31, 2022
@alice-i-cecile
Copy link
Member

I agree with Cart; I don't think this is a useful learning example, and it's not very useful as a test either.

I do like the organizational change though, and I'd be in favor of merging that in a separate PR.

@cart
Copy link
Member

cart commented Mar 31, 2022

Closing this out. Feel free to continue the discussion and I'll re-open if needed.

@cart cart closed this Mar 31, 2022
@mockersf
Copy link
Member Author

I agree this is not an example for users, but it's still useful to be able to hit those parts in CI...

@cart
Copy link
Member

cart commented Mar 31, 2022

We always knew we'd want "real" end-to-end tests eventually (and that examples weren't for that). I'm down to re-open that conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants