[Merged by Bors] - Re-enable test_property_type_registration()#4419
Closed
alice-i-cecile wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Re-enable test_property_type_registration()#4419alice-i-cecile wants to merge 1 commit intobevyengine:mainfrom
alice-i-cecile wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Code-Quality
MrGVSV
approved these changes
Apr 4, 2022
Member
MrGVSV
left a comment
MrGVSV
left a comment
There was a problem hiding this comment.
Looks good but I wonder why there's no non-generic test 🤔 (probably just too trivial?)
Member
Author
Yeah, that's my guess. I'm not sure it would catch any interesting edge cases. |
Member
Author
|
Apparently this test has always been disabled, starting from the first commit on this file: 72b2fc9 |
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
approved these changes
Apr 4, 2022
Member
|
Hmm yeah I dont remember why this was commented out :) |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
# Objective - This test was mysteriously commented out ## Solution - Re-enable it - Also done in #4299, but this is better as its own PR.
Contributor
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - This test was mysteriously commented out ## Solution - Re-enable it - Also done in bevyengine#4299, but this is better as its own PR.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - This test was mysteriously commented out ## Solution - Re-enable it - Also done in bevyengine#4299, but this is better as its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution