[Merged by Bors] - Fixing confusing near and far fields in Camera#4457
Closed
AronDerenyi wants to merge 11 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Fixing confusing near and far fields in Camera#4457AronDerenyi wants to merge 11 commits intobevyengine:mainfrom
AronDerenyi wants to merge 11 commits intobevyengine:mainfrom
Conversation
…e far plane from the camera. Since the camera's far plane was an arbitrary number not derived from the projection, ClusterFarZMode::Constant can be used instead.
superdump
requested changes
Apr 11, 2022
alice-i-cecile
added
A-Rendering
IceSentry
approved these changes
Apr 27, 2022
superdump
requested changes
May 5, 2022
Contributor
superdump
left a comment
superdump
left a comment
There was a problem hiding this comment.
Please test the many_lights example with a 3D orthographic camera and log the appropriate near value as extracted from the orthographic projection to check it is correct. :)
Fixed the near value calculation and added comments Co-authored-by: Robert Swain <robert.swain@gmail.com>
Member
|
I just independently came to the same conclusion with my recent camera work. I think this is a good call. |
cart
reviewed
May 10, 2022
superdump
approved these changes
May 14, 2022
Contributor
superdump
left a comment
superdump
left a comment
There was a problem hiding this comment.
It's a shame to have to remove the CameraFarPlane option, but it's easy enough to configure a constant far plane instead if you need it.
Contributor
Contributor
|
no objection from me. |
robtfm
approved these changes
May 14, 2022
alice-i-cecile
approved these changes
May 16, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Contributor
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 16, 2022
# Objective - Fixes #4456 ## Solution - Removed the `near` and `far` fields from the camera and the views. --- ## Changelog - Removed the `near` and `far` fields from the camera and the views. - Removed the `ClusterFarZMode::CameraFarPlane` far z mode. ## Migration Guide - Cameras no longer accept near and far values during initialization - `ClusterFarZMode::Constant` should be used with the far value instead of `ClusterFarZMode::CameraFarPlane`
Contributor
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 17, 2022
# Objective - Fixes bevyengine#4456 ## Solution - Removed the `near` and `far` fields from the camera and the views. --- ## Changelog - Removed the `near` and `far` fields from the camera and the views. - Removed the `ClusterFarZMode::CameraFarPlane` far z mode. ## Migration Guide - Cameras no longer accept near and far values during initialization - `ClusterFarZMode::Constant` should be used with the far value instead of `ClusterFarZMode::CameraFarPlane`
|
How do you migrate this if you were previously using .near field |
Contributor
What were you using it for? |
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Fixes bevyengine#4456 ## Solution - Removed the `near` and `far` fields from the camera and the views. --- ## Changelog - Removed the `near` and `far` fields from the camera and the views. - Removed the `ClusterFarZMode::CameraFarPlane` far z mode. ## Migration Guide - Cameras no longer accept near and far values during initialization - `ClusterFarZMode::Constant` should be used with the far value instead of `ClusterFarZMode::CameraFarPlane`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#4456 ## Solution - Removed the `near` and `far` fields from the camera and the views. --- ## Changelog - Removed the `near` and `far` fields from the camera and the views. - Removed the `ClusterFarZMode::CameraFarPlane` far z mode. ## Migration Guide - Cameras no longer accept near and far values during initialization - `ClusterFarZMode::Constant` should be used with the far value instead of `ClusterFarZMode::CameraFarPlane`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
nearandfarfields from the camera and the views.Changelog
nearandfarfields from the camera and the views.ClusterFarZMode::CameraFarPlanefar z mode.Migration Guide
ClusterFarZMode::Constantshould be used with the far value instead ofClusterFarZMode::CameraFarPlane