Implement 3d texture as assets#453
Closed
sim-the-bean wants to merge 1 commit intobevyengine:masterfrom
sim-the-bean:texture_3d
Closed
Implement 3d texture as assets#453sim-the-bean wants to merge 1 commit intobevyengine:masterfrom sim-the-bean:texture_3d
sim-the-bean wants to merge 1 commit intobevyengine:masterfrom
sim-the-bean:texture_3d
Conversation
|
Would this be better served as a new Trait that extends the RenderResource trait - something like: I'm still a bit new to Rust, but if I'm understanding traits, this kind of makes sense if we want to write systems specific to 3d textures vs 2d. |
Member
|
Closed in favor of #903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple pr that implements 3d textures as a mostly-copy of 2d textures.
One big, potentially breaking change is that now
RenderResourcerequires an implementation offn texture3d, which works just likefn texture. The derive macro has been updated to support this.I haven't tested this yet properly, so I'm making it a draft until I've verified that this works.