[Merged by Bors] - Clean up advice on glob imports in style guide#4644
Closed
alice-i-cecile wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Clean up advice on glob imports in style guide#4644alice-i-cecile wants to merge 2 commits intobevyengine:mainfrom
alice-i-cecile wants to merge 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
C-Docs
Member
Author
|
@DJMcNab, this is probably as good of a place as any to chat about the appropriateness of this rule, especially for If we want to change it, I can tweak the PR, although that will require @cart sign-off due to its impact on engine-wide style. |
mockersf
reviewed
May 2, 2022
Co-authored-by: François <mockersf@gmail.com>
mockersf
approved these changes
May 2, 2022
Member
Author
|
bors r+ |
Contributor
bors
bot
changed the title
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Example was misleading, as we never import `bevy` itself in the engine (except in integration tests). ## Solution - Clean up wording. ## Context Noticed by @mockersf in bevyengine#4608.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Example was misleading, as we never import `bevy` itself in the engine (except in integration tests). ## Solution - Clean up wording. ## Context Noticed by @mockersf in bevyengine#4608.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevyitself in the engine (except in integration tests).Solution
Context
Noticed by @mockersf in #4608.