[Merged by Bors] - Update layout/style when scale factor changes too#4689
Closed
DJMcNab wants to merge 4 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Update layout/style when scale factor changes too#4689DJMcNab wants to merge 4 commits intobevyengine:mainfrom
DJMcNab wants to merge 4 commits intobevyengine:mainfrom
Conversation
DJMcNab
commented
May 7, 2022
crates/bevy_text/src/text2d.rs
Outdated
| if let Ok((text, bounds, mut calculated_size)) = query.get_mut(entity) { | ||
| let text_bounds = match bounds { | ||
| for (entity, text_changed, text, maybe_bounds, mut calculated_size) in text_query.iter_mut() { | ||
| if factor_changed || text_changed || queue.entities.remove(&entity) { |
Member
Author
There was a problem hiding this comment.
queue.entities.remove might look expensive, but the other changes more than drown out this overhead.
DJMcNab
added
C-Bug
tim-blackbird
suggested changes
May 7, 2022
tim-blackbird
approved these changes
May 7, 2022
Contributor
tim-blackbird
left a comment
tim-blackbird
left a comment
There was a problem hiding this comment.
Neat. I like the comment you added.
Although I find the line break a bit awkward, but I won't block on that.
Co-authored-by: devil ira <JustTheCoolDude@gmail.com>
IceSentry
approved these changes
May 7, 2022
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
I tested the example of the linked issue and this solution worked as expected.
IceSentry
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
# Objective - Fix #4688 ## Solution - Fixes #4688 - This raises an interesting question about our change detection system - is filtered queries actually a good UX for this? They're ergonomic in the easy case, but what do we recommend when it's not so. - In this case, the system should have been migrated similary to #4180 anyway, so I've done that.
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 9, 2022
# Objective - Fix #4688 ## Solution - Fixes #4688 - This raises an interesting question about our change detection system - is filtered queries actually a good UX for this? They're ergonomic in the easy case, but what do we recommend when it's not so. - In this case, the system should have been migrated similary to #4180 anyway, so I've done that.
Contributor
bors
bot
changed the title
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
May 10, 2022
# Objective - Fix bevyengine#4688 ## Solution - Fixes bevyengine#4688 - This raises an interesting question about our change detection system - is filtered queries actually a good UX for this? They're ergonomic in the easy case, but what do we recommend when it's not so. - In this case, the system should have been migrated similary to bevyengine#4180 anyway, so I've done that.
exjam
pushed a commit
to exjam/bevy
that referenced
this pull request
May 22, 2022
# Objective - Fix bevyengine#4688 ## Solution - Fixes bevyengine#4688 - This raises an interesting question about our change detection system - is filtered queries actually a good UX for this? They're ergonomic in the easy case, but what do we recommend when it's not so. - In this case, the system should have been migrated similary to bevyengine#4180 anyway, so I've done that.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fix bevyengine#4688 ## Solution - Fixes bevyengine#4688 - This raises an interesting question about our change detection system - is filtered queries actually a good UX for this? They're ergonomic in the easy case, but what do we recommend when it's not so. - In this case, the system should have been migrated similary to bevyengine#4180 anyway, so I've done that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution