[Merged by Bors] - Use uniform buffer usage for SkinnedMeshUniform instead of all usages#4816
Closed
teoxoy wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Use uniform buffer usage for SkinnedMeshUniform instead of all usages#4816teoxoy wants to merge 2 commits intobevyengine:mainfrom
SkinnedMeshUniform instead of all usages#4816teoxoy wants to merge 2 commits intobevyengine:mainfrom
Conversation
james7132
added
C-Bug
james7132
approved these changes
May 20, 2022
…l()` due to the Default derive
alice-i-cecile
added
the
P-Critical
alice-i-cecile
added
P-High
mockersf
approved these changes
May 20, 2022
mockersf
added
the
S-Ready-For-Final-Review
cart
approved these changes
May 20, 2022
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
This fixes it for me. Nice work!
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 20, 2022
…es (#4816) # Objective fixes #4811 (caused by #4339 [[exact change](https://github.com/bevyengine/bevy/pull/4339/files#diff-4bf3ed03d4129aad9f5678ba19f9b14ee8e3e61d6f6365e82197b01c74468b10R712-R721)] - where the buffer type has been changed from `UniformVec` to `BufferVec`) ## Solution Use uniform buffer usage for `SkinnedMeshUniform` instead of all usages due to the `Default` derive.
Contributor
bors
bot
changed the title
SkinnedMeshUniform instead of all usagesSkinnedMeshUniform instead of all usages
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
…es (bevyengine#4816) # Objective fixes bevyengine#4811 (caused by bevyengine#4339 [[exact change](https://github.com/bevyengine/bevy/pull/4339/files#diff-4bf3ed03d4129aad9f5678ba19f9b14ee8e3e61d6f6365e82197b01c74468b10R712-R721)] - where the buffer type has been changed from `UniformVec` to `BufferVec`) ## Solution Use uniform buffer usage for `SkinnedMeshUniform` instead of all usages due to the `Default` derive.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…es (bevyengine#4816) # Objective fixes bevyengine#4811 (caused by bevyengine#4339 [[exact change](https://github.com/bevyengine/bevy/pull/4339/files#diff-4bf3ed03d4129aad9f5678ba19f9b14ee8e3e61d6f6365e82197b01c74468b10R712-R721)] - where the buffer type has been changed from `UniformVec` to `BufferVec`) ## Solution Use uniform buffer usage for `SkinnedMeshUniform` instead of all usages due to the `Default` derive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
fixes #4811 (caused by #4339 [exact change] - where the buffer type has been changed from
UniformVectoBufferVec)Solution
Use uniform buffer usage for
SkinnedMeshUniforminstead of all usages due to theDefaultderive.