[Merged by Bors] - Remove markdown dead link check#4839
Closed
cart wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Remove markdown dead link check#4839cart wants to merge 2 commits intobevyengine:mainfrom
cart wants to merge 2 commits intobevyengine:mainfrom
Conversation
Member
|
Can you note that this fixes #4575? |
james7132
approved these changes
May 25, 2022
Member
james7132
left a comment
james7132
left a comment
There was a problem hiding this comment.
Probably should delete the config for the check as well. Under .github/linters/markdown-link-check.json
Member
Author
|
Good call. I also removed the relevant bors line (which i totally missed). |
Member
Author
|
bors r+ |
Contributor
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
# Objective This fails constantly and causes more pain than it is worth. ## Solution Remove dead link checks. Alternative to bevyengine#4837, which is more granular but ironically still fails to build. I'm in favor of the nuclear option. Fixes bevyengine#4575
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective This fails constantly and causes more pain than it is worth. ## Solution Remove dead link checks. Alternative to bevyengine#4837, which is more granular but ironically still fails to build. I'm in favor of the nuclear option. Fixes bevyengine#4575
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This fails constantly and causes more pain than it is worth.
Solution
Remove dead link checks.
Alternative to #4837, which is more granular but ironically still fails to build. I'm in favor of the nuclear option.
Fixes #4575