Warn when CameraUI is despawned#4861
Closed
rileysu wants to merge 1 commit intobevyengine:mainfrom
rileysu:main
Closed
Warn when CameraUI is despawned#4861rileysu wants to merge 1 commit intobevyengine:mainfrom rileysu:main
rileysu wants to merge 1 commit intobevyengine:mainfrom
rileysu:main
Conversation
Member
|
It's not clear to me that we should warn here. The fix used in #4527 follows the example of bevy/crates/bevy_core_pipeline/src/main_pass_3d.rs Lines 53 to 56 in d353fbc We definitely should use an early return instead of a huge match block here, even if we do decide we want to warn here (i.e. use this PR). |
Author
|
This seems to be handled in #4527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #4856
Solution
Warn when camera isn't present instead of using
.expect()