Skip to content

[Merged by Bors] - transparency_3d example tweaks#4968

Closed
MiniaczQ wants to merge 4 commits intobevyengine:mainfrom
MiniaczQ:examples/transparency_3d-tweaks
Closed

[Merged by Bors] - transparency_3d example tweaks#4968
MiniaczQ wants to merge 4 commits intobevyengine:mainfrom
MiniaczQ:examples/transparency_3d-tweaks

Conversation

@MiniaczQ
Copy link
Contributor

@MiniaczQ MiniaczQ commented Jun 8, 2022

Fixed a typo, removed unused component, normalized comments added a touch more detail.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jun 8, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye :)

@MiniaczQ
Copy link
Contributor Author

MiniaczQ commented Jun 8, 2022

Actually, before merging, I'd like to add a possible use case of Mask(f32), but I'm not sure myself what it'd be.
It works like a poor's man alpha driven is_visible, because it still renders the shadow. :/
So if anyone is aware what it can/should be used for please let me know so I can add it.

@MiniaczQ
Copy link
Contributor Author

MiniaczQ commented Jun 8, 2022

Okay, so Mask isn't supposed to leave a shadow, guess it's fine to merge then, I'll make an issue for that

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jun 23, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jun 23, 2022
Fixed a typo, removed unused component, normalized comments added a touch more detail.
@bors bors bot changed the title transparency_3d example tweaks [Merged by Bors] - transparency_3d example tweaks Jun 23, 2022
@bors bors bot closed this Jun 23, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
Fixed a typo, removed unused component, normalized comments added a touch more detail.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
Fixed a typo, removed unused component, normalized comments added a touch more detail.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
Fixed a typo, removed unused component, normalized comments added a touch more detail.
@MiniaczQ MiniaczQ deleted the examples/transparency_3d-tweaks branch January 14, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants