[WIP] World query filter proposal prototype implementation.#4997
Closed
Monnoroch wants to merge 1 commit intobevyengine:mainfrom
Closed
[WIP] World query filter proposal prototype implementation.#4997Monnoroch wants to merge 1 commit intobevyengine:mainfrom
Monnoroch wants to merge 1 commit intobevyengine:mainfrom
Conversation
This PR is a prototype implementaton of bevyengine/rfcs#58 RFC that proposes disallowing using component types as query filters. This PR also introduces `derive(WorldQueryFilter)` proc macro to make custom query filters, analogous to custom queries.
alice-i-cecile
added
A-ECS
Member
|
@Monnoroch can you convert this to a "draft" for now? That will make it clear to reviewers that this is WIP :) It also plays better with search filters. |
Member
|
This is now addressed! We use two different traits now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a prototype implementaton of bevyengine/rfcs#58 RFC that proposes disallowing using component types as query filters. This PR also introduces
derive(WorldQueryFilter)proc macro to make custom query filters, analogous to custom queries.