[Merged by Bors] - Default image sampler doc fix#5047
Closed
sarkahn wants to merge 7 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Default image sampler doc fix#5047sarkahn wants to merge 7 commits intobevyengine:mainfrom
sarkahn wants to merge 7 commits intobevyengine:mainfrom
Conversation
Moved ImageSettings into image.rs Changed DefaultImageSampler to RenderDefaultImageSampler Added docs explaining how to set the default image sampler via ImageSettings
Weibye
added
C-Docs
alice-i-cecile
requested changes
Jun 20, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
This is clearer, and I like the reorganization. Can you revert the rename? I don't think the improvement is worth the breaking change.
alice-i-cecile
approved these changes
Jun 20, 2022
mockersf
reviewed
Jun 20, 2022
mockersf
reviewed
Jun 20, 2022
Co-authored-by: François <mockersf@gmail.com>
Co-authored-by: François <mockersf@gmail.com>
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
# Objective Attempt to more clearly document `ImageSettings` and setting a default sampler for new images, as per #5046 ## Changelog - Moved ImageSettings into image.rs, image::* is already exported. Makes it simpler for linking docs. - Renamed "DefaultImageSampler" to "RenderDefaultImageSampler". Not a great name, but more consistent with other render resources. - Added/updated related docs
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective Attempt to more clearly document `ImageSettings` and setting a default sampler for new images, as per bevyengine#5046 ## Changelog - Moved ImageSettings into image.rs, image::* is already exported. Makes it simpler for linking docs. - Renamed "DefaultImageSampler" to "RenderDefaultImageSampler". Not a great name, but more consistent with other render resources. - Added/updated related docs
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Attempt to more clearly document `ImageSettings` and setting a default sampler for new images, as per bevyengine#5046 ## Changelog - Moved ImageSettings into image.rs, image::* is already exported. Makes it simpler for linking docs. - Renamed "DefaultImageSampler" to "RenderDefaultImageSampler". Not a great name, but more consistent with other render resources. - Added/updated related docs
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Attempt to more clearly document `ImageSettings` and setting a default sampler for new images, as per bevyengine#5046 ## Changelog - Moved ImageSettings into image.rs, image::* is already exported. Makes it simpler for linking docs. - Renamed "DefaultImageSampler" to "RenderDefaultImageSampler". Not a great name, but more consistent with other render resources. - Added/updated related docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Attempt to more clearly document
ImageSettingsand setting a default sampler for new images, as per #5046Changelog